-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-49024: [CI] Update Debian version in .env
#49032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit debian preview-docs |
|
|
This comment was marked as outdated.
This comment was marked as outdated.
3ab5893 to
e3e53c0
Compare
|
@github-actions crossbow submit debian preview-docs |
This comment was marked as outdated.
This comment was marked as outdated.
| image: debian-python | ||
|
|
||
| test-debian-12-python-3-i386: | ||
| test-debian-{{ debian_version }}-python-3-i386: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou I've kept some Python builds for Debian oldstable, do you think it is useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you keep them? I think that they are needless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, should we remove debian-12-cpp.dockerfile too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think so. We don't want to keep supporting oldstable.
e3e53c0 to
9fa4901
Compare
|
@github-actions crossbow submit debian preview-docs |
|
Revision: 9fa4901 Submitted crossbow builds: ursacomputing/crossbow @ actions-148f8e7f27 |
| image: debian-python | ||
|
|
||
| test-debian-12-python-3-i386: | ||
| test-debian-{{ debian_version }}-python-3-i386: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you keep them? I think that they are needless.
9fa4901 to
08e689b
Compare
|
@github-actions crossbow submit debian preview-docs |
|
Revision: 08e689b Submitted crossbow builds: ursacomputing/crossbow @ actions-7b6e29dcb4 |
|
I need to fix the failing jemalloc test on Debian 13 i386. Probably by making the test looser, as it is not testing anything important. |
08e689b to
a7a74a4
Compare
|
@github-actions crossbow submit debian preview-docs |
|
Revision: a7a74a4 Submitted crossbow builds: ursacomputing/crossbow @ actions-3bb0b6f71d |
|
@kou Do you want to take another look? |
a7a74a4 to
ff5b68b
Compare
Also prune entries that are not used anymore.
ff5b68b to
860d24d
Compare
|
@github-actions crossbow submit debian |
|
Revision: 860d24d Submitted crossbow builds: ursacomputing/crossbow @ actions-217d66d8e9 |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
### Rationale for this change Default Debian version in `.env` now maps to oldstable, we should use stable instead. Also prune entries that are not used anymore. ### Are these changes tested? By existing CI jobs. ### Are there any user-facing changes? No. * GitHub Issue: #49024 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Default Debian version in
.envnow maps to oldstable, we should use stable instead.Also prune entries that are not used anymore.
Are these changes tested?
By existing CI jobs.
Are there any user-facing changes?
No.
.env#49024